docs: Add guide for running CI tests locally with tox-lsr#796
Merged
richm merged 1 commit intolinux-system-roles:mainfrom Jul 8, 2025
Merged
docs: Add guide for running CI tests locally with tox-lsr#796richm merged 1 commit intolinux-system-roles:mainfrom
richm merged 1 commit intolinux-system-roles:mainfrom
Conversation
Reviewer's GuideIntroduces a new “Running CI Tests Locally” section in contributing.md that guides developers through using tox-lsr and QEMU to execute CI tests on their local machines. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @liangwen12year - I've reviewed your changes - here's some feedback:
- Consider pinning the tox-lsr installation to a stable release tag instead of
@mainto avoid breakage when upstream changes occur. - It may be helpful to note that qemu-based tests require virtualization tools (e.g.
qemu-system-x86_64) and appropriate permissions or root access to launch VMs. - The yum/dnf and pip install commands likely need
sudo; consider explicitly showing when to prefix withsudoto prevent permission issues.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider pinning the tox-lsr installation to a stable release tag instead of `@main` to avoid breakage when upstream changes occur.
- It may be helpful to note that qemu-based tests require virtualization tools (e.g. `qemu-system-x86_64`) and appropriate permissions or root access to launch VMs.
- The yum/dnf and pip install commands likely need `sudo`; consider explicitly showing when to prefix with `sudo` to prevent permission issues.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
==========================================
+ Coverage 43.11% 43.25% +0.13%
==========================================
Files 12 12
Lines 3124 3121 -3
==========================================
+ Hits 1347 1350 +3
+ Misses 1777 1771 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
spetrosi
reviewed
Jul 7, 2025
| 5. Assuming you are in a git clone of a role repo which has a tox.ini file - you can use e.g. | ||
|
|
||
| ```bash | ||
| tox -e qemu-ansible-core-2.14 -- --image-name rhel-9-2 tests/tests_default.yml |
Collaborator
There was a problem hiding this comment.
Upstream users wouldn't be able to use rhel, change to centos-9
Contributor
Author
There was a problem hiding this comment.
I changed it to centos-9, thanks!
Contributor
|
This should also go into https://github.com/linux-system-roles/.github/blob/main/playbooks/templates/contributing.md |
liangwen12year
force-pushed
the
update_docs
branch
4 times, most recently
from
6ea76b1 to
9df2ced
Compare
Signed-off-by: Wen Liang <liangwen12year@gmail.com>
liangwen12year
force-pushed
the
update_docs
branch
from
9df2ced to
ada9434
Compare
Contributor
Author
I created a PR, thanks, linux-system-roles/.github#121. |
richm
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement:
Reason:
Result:
Issue Tracker Tickets (Jira or BZ if any):
Summary by Sourcery
Documentation: